Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean unused vars #1069

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

rsoaresd
Copy link
Contributor

  • clean E2E_MEMBER_NS and E2E_HOST_NS from add deploy-toolchain-resources-e2e #1068 (sorry, i forgot to clean up)
  • move DEFAULT_HOST_NS, DEFAULT_MEMBER_NS= toolchain-member-operator, and DEFAULT_MEMBER_NS_2 to make/dev.mk

Copy link
Collaborator

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
/lgtm

Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc, rajivnathan, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,mfrancisc,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsoaresd
Copy link
Contributor Author

/retest

=== RUN   TestActivationCodeVerification/verification_failed/over_capacity
    host.go:2406: waiting for SocialEvent 'enxfc' in namespace 'toolchain-host-22161254' to match criteria
    registration_service_test.go:794: 
        	Error Trace:	/go/src/github.com/codeready-toolchain/toolchain-e2e/test/e2e/parallel/registration_service_test.go:794
        	Error:      	Received unexpected error:
        	            	Operation cannot be fulfilled on socialevents.toolchain.dev.openshift.com "enxfc": the object has been modified; please apply your changes to the latest version and try again
        	Test:       	TestActivationCodeVerification/verification_failed/over_capacity

First time I saw it. Maybe flaky test

@openshift-ci openshift-ci bot removed the lgtm label Nov 25, 2024
Copy link

openshift-ci bot commented Nov 25, 2024

New changes are detected. LGTM label has been removed.

Copy link

sonarcloud bot commented Nov 25, 2024

@rsoaresd rsoaresd merged commit 924068a into codeready-toolchain:master Nov 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants