-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: clean unused vars #1069
test: clean unused vars #1069
Conversation
rsoaresd
commented
Nov 22, 2024
- clean E2E_MEMBER_NS and E2E_HOST_NS from add deploy-toolchain-resources-e2e #1068 (sorry, i forgot to clean up)
- move DEFAULT_HOST_NS, DEFAULT_MEMBER_NS= toolchain-member-operator, and DEFAULT_MEMBER_NS_2 to make/dev.mk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc, rajivnathan, rsoaresd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest
First time I saw it. Maybe flaky test |
New changes are detected. LGTM label has been removed. |
Quality Gate passedIssues Measures |