Separate notes archive to non-toctree pages #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Having notes archive in the main toctree led to a very long link, which caused a messed up PDF build. - But also maybe the notes archive shouldn't be in the PDF build which would be archived on Zenodo. - This makes a stub notes-archive page, which links (non-toctree) links to the notes archive page (which still gets buildt, but not in the toctree, which means not on the left sidebar) - The primary effect is that the archive from the 2024 workshop isn't included in the PDF or singlehtml builds. Which is probably how it should be anyway. A secondary effect is that there isn't a left sidebar link directly to the 2024 notes (but there is to the page that links them). Review: - Confirm it's not in pdf or singlehtml - Confirm that this is the right choice to make for where it should be visible. - Consider if the notes should be in a zenodo-archived git repo at all (since the repo itself will be archived, right?). I think it's probably OK and consistent with the licenses we had said it would be realesed under - right?
|
Thanks so much! Reviewing ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which caused a messed up PDF build.
would be archived on Zenodo.
links to the notes archive page (which still gets buildt, but not in
the toctree, which means not on the left sidebar)
included in the PDF or singlehtml builds. Which is probably how it
should be anyway. A secondary effect is that there isn't a left
sidebar link directly to the 2024 notes (but there is to the page
that links them).
Review:
visible.
(since the repo itself will be archived, right?). I think it's
probably OK and consistent with the licenses we had said it would be
realesed under - right?