-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump snakemake-minimal version to 8.5.3 #16
Conversation
… 8.5.3. Add graphviz dependency required by the dot command.
Thanks Teemu. Is this related to the upcoming workshop? Because today is basically the last day we can change the environment because this afternoon we have the first install help session. If yes, we should also change https://github.com/coderefinery/software ? |
Yes it is and yes let's update there as well |
OK then I have to do it basically now. But first I need to send out email to all participants and I will work on the rest later. |
Just looking into it. There seems to be some trouble... Fixing in an hour. Please do not merge yet |
Heip, yeah Samantha asked me to check if the lesson works with the new Snakemake version. There were a lot of breaking changes going from 7.x to 8.x. However, the changes seem to only concern advanced features such as cluster submissions. So, the basic features shown in the lesson have not been changed and if you encounter any problems (although I didn't), I would just postpone the version bump. Good to do at some point, but no need to do it right now. |
Hei @samumantha, did you find and/or fix some errors? |
We have fixed the problems with the last commit. See also coderefinery/software#34. |
Ok, I took away the draft status, @bast do you want to merge? (You probably know best how you want to do it, squash or not etc.) |
Thank you! |
The snakemake-minimal version 7.22 is a bit outdated, the latest is 8.5.3. However, the basic functionality of Snakemake used in the exercise hasn't changed so 7.22 is also fine.
Tested the exercises and running them with version 8.5.3 did not require any other changes.