Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snakemake-minimal version to 8.5.3 #16

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

ruokolt
Copy link
Contributor

@ruokolt ruokolt commented Mar 4, 2024

The snakemake-minimal version 7.22 is a bit outdated, the latest is 8.5.3. However, the basic functionality of Snakemake used in the exercise hasn't changed so 7.22 is also fine.

Tested the exercises and running them with version 8.5.3 did not require any other changes.

@ruokolt ruokolt requested review from bast and samumantha March 4, 2024 14:34
@ruokolt ruokolt marked this pull request as draft March 4, 2024 14:35
@bast
Copy link
Member

bast commented Mar 5, 2024

Thanks Teemu. Is this related to the upcoming workshop? Because today is basically the last day we can change the environment because this afternoon we have the first install help session.

If yes, we should also change https://github.com/coderefinery/software ?

@samumantha
Copy link
Contributor

Yes it is and yes let's update there as well

@bast
Copy link
Member

bast commented Mar 5, 2024

OK then I have to do it basically now. But first I need to send out email to all participants and I will work on the rest later.

@samumantha
Copy link
Contributor

Just looking into it. There seems to be some trouble... Fixing in an hour. Please do not merge yet

@ruokolt
Copy link
Contributor Author

ruokolt commented Mar 5, 2024

Heip, yeah Samantha asked me to check if the lesson works with the new Snakemake version. There were a lot of breaking changes going from 7.x to 8.x. However, the changes seem to only concern advanced features such as cluster submissions. So, the basic features shown in the lesson have not been changed and if you encounter any problems (although I didn't), I would just postpone the version bump. Good to do at some point, but no need to do it right now.

@ruokolt ruokolt changed the title Bump snakemake minimal version to 8.5.3 Bump snakemake-minimal version to 8.5.3 Mar 5, 2024
@ruokolt
Copy link
Contributor Author

ruokolt commented Mar 5, 2024

Just looking into it. There seems to be some trouble... Fixing in an hour. Please do not merge yet

Hei @samumantha, did you find and/or fix some errors?

@bast
Copy link
Member

bast commented Mar 5, 2024

We have fixed the problems with the last commit. See also coderefinery/software#34.

@ruokolt ruokolt marked this pull request as ready for review March 5, 2024 17:34
@ruokolt
Copy link
Contributor Author

ruokolt commented Mar 5, 2024

Ok, I took away the draft status, @bast do you want to merge? (You probably know best how you want to do it, squash or not etc.)

@bast bast merged commit 9b9f7d9 into main Mar 5, 2024
@bast
Copy link
Member

bast commented Mar 5, 2024

Thank you!

@bast bast deleted the bump-snakemake-minimal-version-to-8.5.3 branch March 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants