Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent_farm] we are removing the last empty line in the file (Run ID: codestoryai_sidecar_issue_2044_6dfb8e77) #2045

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theskcd
Copy link
Contributor

@theskcd theskcd commented Feb 12, 2025

agent_instance: codestoryai_sidecar_issue_2044_6dfb8e77 Tries to fix: #2044

Bug Fix: Resolved issue where the final newline character was being removed during code edits. This fix modifies the update_code_lines method within the SearchAndReplaceAccumulator to preserve final newlines, including cases with empty files or no trailing newlines. Please review!

@theskcd
Copy link
Contributor Author

theskcd commented Feb 12, 2025

/agent the edits look wrong to me, please make sure they are correct and use cargo test to verify

@theskcd
Copy link
Contributor Author

theskcd commented Feb 12, 2025

Bug Fix: Resolved issue where the final newline character was being removed during code edits. This fix modifies the update_code_lines method within the SearchAndReplaceEditingAccumulator to preserve final newlines, including cases with empty files or no trailing newlines. Please review!

@theskcd
Copy link
Contributor Author

theskcd commented Feb 12, 2025

/agent run cargo test to make sure nothing breaks

@theskcd
Copy link
Contributor Author

theskcd commented Feb 12, 2025

/feedback long files still mess up the agent, which is good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[agent_farm] we are removing the last empty line in the file
1 participant