Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline file rights #2033

Merged
merged 26 commits into from
Dec 11, 2023
Merged

Inline file rights #2033

merged 26 commits into from
Dec 11, 2023

Conversation

tf
Copy link
Member

@tf tf commented Dec 11, 2023

REDMINE-20093

@tf tf added this to the v16.2 milestone Dec 11, 2023
@tf tf force-pushed the inline-file-rights branch 3 times, most recently from a3855cb to a8e592f Compare December 11, 2023 09:38
tf added 26 commits December 11, 2023 13:35
Inline file right widgets need to be available in section thumbnails.

REDMINE-20093
* Support nested items
* Support Backbone model constructor as items

REDMINE-20093
Extend file with license information and flag to control whether
inline file rights should be displayed. Provide component to render
inline file rights while using inline file rights widget to control
presentation.

REDMINE-20093
Allow rendering additional control bar button which does not fade
together other control bar buttons.

REDMINE-20093
Allow inserting additional control bar button at the end of control
bar.

REDMINE-20093
We intend to pull up the logic that decides which files to render in
the backdrop into a hook on section to make file available for inline
rights display. So far, we prevented creating unneeded orientation
media queries by rendering `OrientationAwareBackgroundImage/Video`
components that used the media query hook only when portrait files
were present.

We now need a way to be able to always call the
`usePortraitOrientation` hook, but prevent it from creating the media
query if no portrait files have been configured.

REDMINE-20093
Allow reading backdrop file info from backdrop object in section.

REDMINE-20093
Required to make `useFileWithInlineRights` in `useBackdrop` pick it
up.

REDMINE-20093
Filter file that display rights inline.

REDMINE-20093
Let long values overflow with ellipsis.

REDMINE-20093
@tf tf force-pushed the inline-file-rights branch from a8e592f to 508342b Compare December 11, 2023 12:35
@tf tf merged commit 79b79a1 into codevise:master Dec 11, 2023
16 checks passed
@tf tf deleted the inline-file-rights branch December 11, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant