-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline file rights #2033
Merged
Merged
Inline file rights #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf
force-pushed
the
inline-file-rights
branch
3 times, most recently
from
December 11, 2023 09:38
a3855cb
to
a8e592f
Compare
REDMINE-20093
Inline file right widgets need to be available in section thumbnails. REDMINE-20093
REDMINE-20093
* Support nested items * Support Backbone model constructor as items REDMINE-20093
Extend file with license information and flag to control whether inline file rights should be displayed. Provide component to render inline file rights while using inline file rights widget to control presentation. REDMINE-20093
Allow rendering additional control bar button which does not fade together other control bar buttons. REDMINE-20093
Allow inserting additional control bar button at the end of control bar. REDMINE-20093
REDMINE-20093
REDMINE-20093
We intend to pull up the logic that decides which files to render in the backdrop into a hook on section to make file available for inline rights display. So far, we prevented creating unneeded orientation media queries by rendering `OrientationAwareBackgroundImage/Video` components that used the media query hook only when portrait files were present. We now need a way to be able to always call the `usePortraitOrientation` hook, but prevent it from creating the media query if no portrait files have been configured. REDMINE-20093
Allow reading backdrop file info from backdrop object in section. REDMINE-20093
REDMINE-20093
REDMINE-20093
REDMINE-20093
Required to make `useFileWithInlineRights` in `useBackdrop` pick it up. REDMINE-20093
Filter file that display rights inline. REDMINE-20093
Let long values overflow with ellipsis. REDMINE-20093
REDMINE-20093
REDMINE-20093
REDMINE-20093
tf
force-pushed
the
inline-file-rights
branch
from
December 11, 2023 12:35
a8e592f
to
508342b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-20093