Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple host application from scrolled widget packs #2035

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Decouple host application from scrolled widget packs #2035

merged 1 commit into from
Dec 11, 2023

Conversation

tf
Copy link
Member

@tf tf commented Dec 11, 2023

Implicitly define packs via pageflow-scrolled/config. Allow importing all widget for SSR.

Manual Update Step

  • Remove defaultNavigation.js and consentBar.js from app/javascript/packs/pageflow-scrolled/widgets
  • Import pageflow-scrolled/widgets-server instead of pageflow-scrolled/widgets/defaultNavigation and pageflow-scrolled/widgets/consentBar in app/javascript/packs/pageflow-scrolled-server.js

REDMINE-20093

@tf
Decouple host application from scrolled widget packs
631a636 
Implicitly define packs via pageflow-scrolled/config. Allow importing
all widget for SSR.

REDMINE-20093
@tf tf added this to the v16.2 milestone Dec 11, 2023
@tf tf merged commit fcfed93 into codevise:master Dec 11, 2023
15 checks passed
@tf tf deleted the widget-packs branch December 11, 2023 12:34
@tf tf mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
manual update step
Projects
None yet
Milestone
v16.2
Development

Successfully merging this pull request may close these issues.
1 participant
@tf