Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn external links element into teasers element #2188

Merged
merged 19 commits into from
Jan 20, 2025

Conversation

tf
Copy link
Member

@tf tf commented Jan 10, 2025

REDMINE-20852, REDMINE-20896

@tf tf added this to the v17.1 milestone Jan 10, 2025
@tf tf force-pushed the teasers-inline-editing branch 3 times, most recently from b22741d to 605c53e Compare January 16, 2025 14:11
tf added 19 commits January 17, 2025 18:03
Will be handled by EditableLink.

REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
Remove workaround that broke inline rights copyright buttons.

REDMINE-20852, REDMINE-20896
Generally, wrapping an element in an editable link should not change
percentage sizes relative to its previous containing block.

REDMINE-20852, REDMINE-20896
Prevent toolbar from being clipped by viewport or smaller containers
like teaser cards.

REDMINE-20852, REDMINE-20896
Setting the element to inert for some reason causes `selectionchange`
event not to be fired.

REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
Align with hotspots behavior. Make it easier to create multiple items.

REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
Keep supporting `title` value in CSS to stay compatible for the few
users that already use the feature. We accept that the editor drop
down will show "Below text".

REDMINE-20852, REDMINE-20896
REDMINE-20852, REDMINE-20896
@tf tf force-pushed the teasers-inline-editing branch from 605c53e to 7eab279 Compare January 17, 2025 17:12
@tf tf marked this pull request as ready for review January 20, 2025 14:29
@tf tf merged commit 100e6fb into codevise:master Jan 20, 2025
13 checks passed
@tf tf deleted the teasers-inline-editing branch January 20, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant