Add new volunteer Yakumwamba #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yakumwamba
changed the title
data/users/codewithyaku.json
Outdated
| "categories": [ | ||
| { | ||
| "slug": "Programming | Blockchain | Full-stack-development", | ||
| "topics": ["JavaScript", "TypeScript", "Go", "Blockchain"] |
There was a problem hiding this comment.
Would be better to limit these to 2-3.
data/users/codewithyaku.json
Outdated
| "image": "https://avatars.githubusercontent.com/u/72974932?v=4", | ||
| "categories": [ | ||
| { | ||
| "slug": "Programming | Blockchain | Full-stack-development", |
There was a problem hiding this comment.
Slugs are pre-defined based on category on website. Here is the list
| @@ -4,7 +4,7 @@ | |||
| "image": "https://avatars.githubusercontent.com/u/86418083", | |||
| "categories": [ | |||
| { | |||
| "slug": "web-development", | |||
| "slug": "ç", | |||
There was a problem hiding this comment.
revert changes in this file
| }, | ||
| { | ||
| "name": "Blockchain Development", | ||
| "slug": "blockchain" |
There was a problem hiding this comment.
i see you are not using this tag so can revert this too
| }, | ||
| { | ||
| "slug": "software-development", | ||
| "topics": ["Python","Go"] |
There was a problem hiding this comment.
nit: topic names in smallcase
Also python go and javascript should go in programming. Blockchain can be dropped from programming
|
@Yakumwamba Can you update the file as per comments please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I'm Yaku, thanks for the invite ✨