nix: make derivation and update shell #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markoburcul
force-pushed
the
create-derivation
branch
from
fadb206 to
a5bc0bd
Compare
markoburcul
force-pushed
the
create-derivation
branch
from
a5bc0bd to
ce38490
Compare
jakubgs
approved these changes
Dec 3, 2024
flake.nix
Outdated
Comment on lines
15
to
19
| forEach = nixpkgs.lib.genAttrs; | ||
| forAllSystems = forEach stableSystems; | ||
| pkgsFor = forEach stableSystems ( | ||
| system: import nixpkgs { inherit system; } | ||
| ); |
There was a problem hiding this comment.
Still don't get why this change happened.
jakubgs
reviewed
Dec 4, 2024
Comment on lines
+29
to
+27
| codex = build ["all"]; | ||
| default = codex; |
There was a problem hiding this comment.
One weird thing I found when testing was that if I specify target with #codex or #default it builds, but if I leave that out then it fails with:
> nix build --print-build-logs --print-out-paths '.?submodules=1'
warning: Git tree '/home/jakubgs/work/nim-codex' is dirty
codex> Running phase: unpackPhase
codex> unpacking source archive /nix/store/k9ri8k88313z6ggkcm4k95aaapqw351i-source
codex> source root is source
codex> Running phase: patchPhase
codex> Running phase: updateAutotoolsGnuConfigScriptsPhase
codex> Running phase: configurePhase
codex> Running phase: buildPhase
codex> build flags: SHELL=/nix/store/516kai7nl5dxr792c0nzq0jp8m4zvxpi-bash-5.2p32/bin/bash all V=2 USE_SYSTEM_NIM=1
codex> Git submodules not found. Running 'git submodule update --init --recursive'.
codex> 0.1.0-dirty
codex> make: Nothing to be done for 'all'.
codex> Running phase: installPhase
codex> cp: cannot stat 'build/codex': No such file or directory
Surprisingly .?submodules=1# works fine, so that smells like a nix interpreter bug that ignores the submodules arg.
markoburcul
force-pushed
the
create-derivation
branch
6 times, most recently
from
b0281b0 to
817dbb9
Compare
Create a structure for nix files. Add the derivation file which is using system Nim to compile Codex. Referenced issue: #940 Signed-off-by: markoburcul <[email protected]>
Include commit which allows building circom-compat-ffi using Nix(doesn't affect current usage of the submodule). Referenced issue: #940 Signed-off-by: markoburcul <[email protected]>
Signed-off-by: markoburcul <[email protected]>
markoburcul
force-pushed
the
create-derivation
branch
from
817dbb9 to
bf63cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a structure for nix files. Add the derivation file which is using system Nim to compile Codex. Move shell definition to a specific file.
Referenced issue: #940