Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nim-ethers #1012

Closed
wants to merge 1 commit into from
Closed

Update nim-ethers #1012

wants to merge 1 commit into from

Conversation

marcinczenko
Copy link
Contributor

We released the new version of nim-ethers and as the changes applied by Adam are braking changes I am just kicking it out here.

Mark suggested to create a new release tag with version 1.0.0 (as we have a braking change and this is what we agreed to do on the first occasion).

I can create that one tomorrow.

To fix the compilation errors coming from the new API, I would need to better understand the intention of introducing the Result type.

Is the intention to do something like this

proc onEvent(event: ?!StorageRequested) {.upraises:[].} =
  if e =? event:
    callback(e.requestId, e.ask, e.expiry)

or

OnRequest* = proc(id: ?!RequestId,
                  ask: ?!StorageAsk,
                  expiry: ?!UInt256) {.gcsafe, upraises:[].}

or something else?

@marcinczenko marcinczenko marked this pull request as draft November 28, 2024 19:20
@AuHau
Copy link
Member

AuHau commented Nov 28, 2024

There is my PR open that brings the latest nim-ethers here: #985

So IMHO this one is not needed.

@marcinczenko
Copy link
Contributor Author

Closing in favour of #985.

@marcinczenko marcinczenko deleted the chore/update-nim-ethers branch November 28, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants