-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concurrency issues #993
Commits on Nov 13, 2024
-
Use http subscriptions instead of websocket for tests
To work around this issue when subscriptions are inactive for more than 5 minutes: NomicFoundation/hardhat#2053 Use 100 millisecond polling; default polling interval of 4 seconds is too close to the 5 second timeout for `check eventually`.
Configuration menu - View commit details
-
Copy full SHA for ce6d579 - Browse repository at this point
Copy the full SHA ce6d579View commit details -
use .confirm(1) instead of confirm(0)
confirm(0) doesn't wait at all, confirm(1) waits for the transaction to be mined
Configuration menu - View commit details
-
Copy full SHA for abecadc - Browse repository at this point
Copy the full SHA abecadcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c57b4cd - Browse repository at this point
Copy the full SHA c57b4cdView commit details -
update nim-ethers to version 0.10.0
includes fixes for http polling and .confirm()
Configuration menu - View commit details
-
Copy full SHA for 77a6d0f - Browse repository at this point
Copy the full SHA 77a6d0fView commit details -
fix timing of marketplace tests
allow for a bit more time to withdraw funds
Configuration menu - View commit details
-
Copy full SHA for 66bb2ab - Browse repository at this point
Copy the full SHA 66bb2abView commit details -
use .confirm(1) in marketplace tests
to ensure that the transaction has been processed before continuing with the test
Configuration menu - View commit details
-
Copy full SHA for eb74a6d - Browse repository at this point
Copy the full SHA eb74a6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5ec80b - Browse repository at this point
Copy the full SHA a5ec80bView commit details -
there were two logic errors in this test: - a slot is freed anyway at the end of the contract - when starting the request takes a long time, the first slot can already be freed because there were too many missing proofs
Configuration menu - View commit details
-
Copy full SHA for a901da8 - Browse repository at this point
Copy the full SHA a901da8View commit details -
fix intermittent error in contract tests
currentTime() doesn't always correctly reflect the time of the next transaction
Configuration menu - View commit details
-
Copy full SHA for 0f7f913 - Browse repository at this point
Copy the full SHA 0f7f913View commit details -
reduce number of slots in integration test
otherwise the windows runner in the CI won't be able to start the request before it expires
Configuration menu - View commit details
-
Copy full SHA for d770ac9 - Browse repository at this point
Copy the full SHA d770ac9View commit details -
allow for a bit more time for a request to be submitted
Configuration menu - View commit details
-
Copy full SHA for b9d1ec7 - Browse repository at this point
Copy the full SHA b9d1ec7View commit details
Commits on Nov 14, 2024
-
fix timing of request submission in test
windows ci is so slow, it can take up to 40 seconds just to submit a storage request to hardhat
Configuration menu - View commit details
-
Copy full SHA for ed9910e - Browse repository at this point
Copy the full SHA ed9910eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 523e8cb - Browse repository at this point
Copy the full SHA 523e8cbView commit details -
adjust timing of integration tests
reason: with the increased period length of 90 seconds, it can take longer to wait for a stable challenge at the beginning of a period.
Configuration menu - View commit details
-
Copy full SHA for 90e3686 - Browse repository at this point
Copy the full SHA 90e3686View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0410f99 - Browse repository at this point
Copy the full SHA 0410f99View commit details -
apparently it takes windows 2-3 seconds to resolve "localhost" to 127.0.0.1 for every json-rpc connection that we make 🤦
Configuration menu - View commit details
-
Copy full SHA for 69122d8 - Browse repository at this point
Copy the full SHA 69122d8View commit details