Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency issues #993

Merged
merged 16 commits into from
Nov 25, 2024
Merged

Fix concurrency issues #993

merged 16 commits into from
Nov 25, 2024

Commits on Nov 13, 2024

  1. Use http subscriptions instead of websocket for tests

    To work around this issue when subscriptions are
    inactive for more than 5 minutes:
    NomicFoundation/hardhat#2053
    
    Use 100 millisecond polling; default polling interval
    of 4 seconds is too close to the 5 second timeout for
    `check eventually`.
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ce6d579 View commit details
    Browse the repository at this point in the history
  2. use .confirm(1) instead of confirm(0)

    confirm(0) doesn't wait at all, confirm(1) waits
    for the transaction to be mined
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    abecadc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c57b4cd View commit details
    Browse the repository at this point in the history
  4. update nim-ethers to version 0.10.0

    includes fixes for http polling and .confirm()
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    77a6d0f View commit details
    Browse the repository at this point in the history
  5. fix timing of marketplace tests

    allow for a bit more time to withdraw funds
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    66bb2ab View commit details
    Browse the repository at this point in the history
  6. use .confirm(1) in marketplace tests

    to ensure that the transaction has been processed
    before continuing with the test
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    eb74a6d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a5ec80b View commit details
    Browse the repository at this point in the history
  8. fix proof integration test

    there were two logic errors in this test:
    - a slot is freed anyway at the end of the contract
    - when starting the request takes a long time, the
      first slot can already be freed because there were
      too many missing proofs
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a901da8 View commit details
    Browse the repository at this point in the history
  9. fix intermittent error in contract tests

    currentTime() doesn't always correctly reflect
    the time of the next transaction
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0f7f913 View commit details
    Browse the repository at this point in the history
  10. reduce number of slots in integration test

    otherwise the windows runner in the CI won't
    be able to start the request before it expires
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d770ac9 View commit details
    Browse the repository at this point in the history
  11. fix timing in purchasing test

    allow for a bit more time for a request to
    be submitted
    markspanbroek committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b9d1ec7 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. fix timing of request submission in test

    windows ci is so slow, it can take up to 40 seconds
    just to submit a storage request to hardhat
    markspanbroek committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ed9910e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    523e8cb View commit details
    Browse the repository at this point in the history
  3. adjust timing of integration tests

    reason: with the increased period length of 90 seconds, it
    can take longer to wait for a stable challenge at the
    beginning of a period.
    markspanbroek committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    90e3686 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0410f99 View commit details
    Browse the repository at this point in the history
  5. Fix slow builds on windows

    apparently it takes windows 2-3 seconds to
    resolve "localhost" to 127.0.0.1 for every
    json-rpc connection that we make 🤦
    markspanbroek committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    69122d8 View commit details
    Browse the repository at this point in the history