Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tour more page configurable per instance #840

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

Taeir
Copy link
Contributor

@Taeir Taeir commented Aug 18, 2022

The tour's "more" page contains a long explanation of codidact, communities and how meta works. For instances not hosted as part of Codidact, this does not make sense.

This PR does the following:

  • Add (global) site settings to control the content of the tour more page
  • Update indentation of tour pages to match with other pages in the codebase.
  • Add missing codidactyl.png asset (very important!)

Note: This requires seeding the database (or at least the site settings part of it) again. Since it skips things that are already there, that should prove no issue.

Related to #826 (fixes part of)

@cellio
Copy link
Member

cellio commented Aug 18, 2022

Sounds like a great idea, thanks! One question for review (@ArtOfCode- ): is it ok to add the Codidactyl image in the repo or does it get special licensing, and if we can't add it, what should we do for the tour? (My unofficial opinion is that it's ok to add the Codidactyl's "personality" into the repo; this isn't the blue logo that we might want to protect more, and the tour needs a "host" of some sort. But I defer to people who know more about this stuff than I do.)

Art, normally I'd ask @luap42 to review this (as the author of the tour) but given availability constraints, I'm asking you to do it.

@cellio cellio requested a review from ArtOfCode- August 18, 2022 14:33
@ArtOfCode-
Copy link
Member

I see no issues with including the Codidactyl in the repo, that should be fine.

- Add (global) site settings to control the content of the tour more page
- Update indentation of tour pages to match with other pages in the
system.
- Add missing codidactyl.png asset (very important!)
@eip-ewi eip-ewi force-pushed the tour-customization branch from fffee31 to 4146c50 Compare August 18, 2022 15:27
Copy link
Member

@ArtOfCode- ArtOfCode- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taeir
Copy link
Contributor Author

Taeir commented Aug 18, 2022

I updated some of the description strings of the site settings just now and force pushed that (to not clutter up the history).

@cellio cellio merged commit 89e6ba0 into codidact:develop Aug 18, 2022
@eip-ewi eip-ewi deleted the tour-customization branch August 27, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants