DEV2-4200: Fix inconsistent behavior (also DEV2-3330)

Common/src/main/java/com/tabnineCommon/binary/requests/login/LogoutRequest.kt

@@ -3,12 +3,16 @@ package com.tabnineCommon.binary.requests.login
 import com.tabnineCommon.binary.BinaryRequest
 import com.tabnineCommon.binary.requests.EmptyResponse
 
-class LogoutRequest : BinaryRequest<EmptyResponse> {
+class LogoutRequest(private val onSuccessFn: (() -> Unit)? = null) : BinaryRequest<EmptyResponse> {
     override fun response(): Class<EmptyResponse> {
         return EmptyResponse::class.java
     }
 
     override fun serialize(): Any {
         return mapOf("Logout" to this)
     }
+
+    override fun onSuccess(response: EmptyResponse?) {
+        onSuccessFn?.let { it() }
+    }
 }

Common/src/main/java/com/tabnineCommon/capabilities/CapabilitiesService.java

@@ -12,8 +12,9 @@
 import com.tabnineCommon.binary.requests.capabilities.RefreshRemotePropertiesRequest;
 import com.tabnineCommon.config.Config;
 import com.tabnineCommon.general.DependencyContainer;
-import com.tabnineCommon.lifecycle.BinaryCapabilitiesChangeNotifier;
+import com.tabnineCommon.lifecycle.CapabilitiesStateSingleton;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
@@ -31,7 +32,6 @@ public class CapabilitiesService {
 
   private final BinaryRequestFacade binaryRequestFacade =
       DependencyContainer.instanceOfBinaryRequestFacade();
-  private final Set<Capability> enabledCapabilities = new HashSet<>();
 
   public static CapabilitiesService getInstance() {
     return ServiceManager.getService(CapabilitiesService.class);
@@ -45,9 +45,18 @@ public boolean isCapabilityEnabled(Capability capability) {
     if (Config.IS_SELF_HOSTED) {
       return true;
     }
-    synchronized (enabledCapabilities) {
-      return enabledCapabilities.contains(capability);
-    }
+
+    return CapabilitiesStateSingleton.getInstance()
+        .getOptional()
+        .map(c -> c.isEnabled(capability))
+        .orElse(false);
+  }
+
+  public boolean isReady() {
+    return CapabilitiesStateSingleton.getInstance()
+        .getOptional()
+        .map(Capabilities::isReady)
+        .orElse(false);
   }
 
   public void forceRefreshCapabilities() {
@@ -84,11 +93,6 @@ private void fetchCapabilitiesLoop() {
             lastRefresh = Optional.of(System.currentTimeMillis());
             lastPid = Optional.of(pid);
           }
-          if (!enabledCapabilities.isEmpty()) {
-            this.messageBus
-                .syncPublisher(BinaryCapabilitiesChangeNotifier.CAPABILITIES_CHANGE_NOTIFIER_TOPIC)
-                .notifyFetched();
-          }
         } catch (Throwable t) {
           Logger.getInstance(getClass()).debug("Unexpected error. Capabilities refresh failed", t);
         }
@@ -114,19 +118,16 @@ private void fetchCapabilities() {
   }
 
   private void setCapabilities(CapabilitiesResponse capabilitiesResponse) {
-    synchronized (enabledCapabilities) {
-      Set<Capability> newCapabilities = new HashSet<>();
-
-      capabilitiesResponse.getEnabledFeatures().stream()
-          .filter(Objects::nonNull)
-          .forEach(newCapabilities::add);
-
-      if (!newCapabilities.equals(enabledCapabilities)) {
-        enabledCapabilities.clear();
-        enabledCapabilities.addAll(newCapabilities);
-        CapabilityNotifier.Companion.publish(
-            new Capabilities(newCapabilities, capabilitiesResponse.getExperimentSource()));
-      }
+    Set<Capability> newCapabilities = new HashSet<>();
+    List<Capability> capabilities = capabilitiesResponse.getEnabledFeatures();
+
+    if (capabilities != null) {
+      capabilities.stream().filter(Objects::nonNull).forEach(newCapabilities::add);
     }
+
+    Capabilities newCapabilitiesState =
+        new Capabilities(newCapabilities, capabilitiesResponse.getExperimentSource());
+
+    CapabilitiesStateSingleton.getInstance().set(newCapabilitiesState);
   }
 }

Common/src/main/java/com/tabnineCommon/chat/ChatDisabledComponents.kt

@@ -7,22 +7,49 @@ import javax.swing.JEditorPane
 import javax.swing.event.HyperlinkEvent
 import javax.swing.event.HyperlinkListener
 
-val LOGIN_BUTTON = "<p>If you already have access to chat, please <a href=\"https://app.tabnine.com/signin\">sign in</a></p>".trimIndent()
+const val FEATURE_MISSING = """<html>
+                <body style="padding: 20px;">
+                    <div style="font-size: 12px; margin-bottom: 8px"><b>Tabnine Chat is currently in Beta</b></div>
+                    <div style="font-size: 10px;">
+                        <p style="margin-bottom: 8px">We understand that waiting for this awesome feature isn’t easy, but we guarantee it will be worth it.</p>
+                        <p style="margin-bottom: 8px">Tabnine Chat will soon be available to all users, and we'll make sure to keep you informed. Thank you for your patience! <a href="https://www.tabnine.com/#ChatSection"> Learn more</a></p>
+                    </div>
+                </body>
+            </html>
+        """
 
-fun createChatDisabledJPane(isLoggedIn: Boolean = false): JEditorPane {
-    val pane = JEditorPane(
-        "text/html",
-        """<html>
+const val PLEASE_LOGIN = """<html>
                 <body style="padding: 20px;">
                     <div style="font-size: 12px; margin-bottom: 8px"><b>Tabnine Chat is currently in Beta</b></div>
                     <div style="font-size: 10px;">
                         <p style="margin-bottom: 8px">We understand that waiting for this awesome feature isn’t easy, but we guarantee it will be worth it.</p>
                         <p style="margin-bottom: 8px">Tabnine Chat will soon be available to all users, and we'll make sure to keep you informed. Thank you for your patience! <a href="https://www.tabnine.com/#ChatSection"> Learn more</a></p>
-                        ${if (!isLoggedIn) LOGIN_BUTTON else ""}
+                        <p>If you already have access to chat, please <a href="https://app.tabnine.com/signin">sign in</a></p>
                     </div>
                 </body>
             </html>
-        """.trimIndent()
+        """
+
+const val NEED_TO_BE_PART_OF_A_TEAM = """<html>
+                <body style="padding: 20px;">
+                    <div style="font-size: 12px; margin-bottom: 8px"><b>Tabnine Chat</b></div>
+                    <div style="font-size: 10px;">
+                        <p style="margin-bottom: 8px">To use Tabnine chat please make sure you are part of a team.</p>
+                    </div>
+                </body>
+            </html>
+        """
+
+fun createChatDisabledJPane(chatDisabledReason: ChatDisabledReason): JEditorPane {
+    val htmlContent = when (chatDisabledReason) {
+        ChatDisabledReason.AUTHENTICATION_REQUIRED -> PLEASE_LOGIN
+        ChatDisabledReason.FEATURE_REQUIRED -> FEATURE_MISSING
+        ChatDisabledReason.PART_OF_A_TEAM_REQUIRED -> NEED_TO_BE_PART_OF_A_TEAM
+    }
+
+    val pane = JEditorPane(
+        "text/html",
+        htmlContent.trimIndent()
     ).apply {
         isEditable = false
         isOpaque = false

Common/src/main/java/com/tabnineCommon/chat/ChatDisabledReason.kt

@@ -0,0 +1,29 @@
+package com.tabnineCommon.chat
+
+data class ChatState private constructor(
+    val enabled: Boolean,
+    val loading: Boolean,
+    val chatDisabledReason: ChatDisabledReason?
+) {
+    companion object {
+        @JvmStatic
+        fun enabled() = ChatState(enabled = true, loading = false, null)
+
+        @JvmStatic
+        fun loading() = ChatState(enabled = false, loading = true, null)
+
+        @JvmStatic
+        fun disabled(reason: ChatDisabledReason) = ChatState(
+            enabled = false,
+            loading =
+            false,
+            reason
+        )
+    }
+}
+
+enum class ChatDisabledReason {
+    AUTHENTICATION_REQUIRED,
+    FEATURE_REQUIRED,
+    PART_OF_A_TEAM_REQUIRED,
+}