Merge pull request #13 from coengage-com/add_outgoing_email_fn

Send `from_name` to the outgoing email request API
coengage-com · Jul 1, 2024 · 0d3102a · 0d3102a
2 parents 2a4deac + 3dce90c
commit 0d3102a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/email_service_client/client/resources.py b/email_service_client/client/resources.py
@@ -68,6 +68,7 @@ def __init__(self, session: requests.Session) -> None:
 
     def create(self, data: OutgoingEmailRequestPayload) -> List[OutgoingEmailRequestResponse]:
         form_data = [
+            ("from_name", data["from_name"]),
             ("from_address", data["from_address"]),
             *[("recipients", recipient) for recipient in data["recipients"]],
             *[("cc", cc) for cc in data["cc"]],

diff --git a/email_service_client/tests/unit_tests/email_identity_resource_tests.py b/email_service_client/tests/unit_tests/email_identity_resource_tests.py
@@ -125,6 +125,7 @@ def test_create(self, multipart_encoder_patch):
         )
         multipart_encoder_patch.assert_called_with(
             fields=[
+                ("from_name", "John"),
                 ("from_address", "john@coengagage.com"),
                 ("recipients", "jane@plivo.com"),
                 ("recipients", "kane@plivo.com"),