Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mutations): createOrUpdateCooccurrence should return id properly #327

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix(mutations): createOrUpdateCooccurrence should return id properly #327

merged 2 commits into from
Jan 3, 2024

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jan 2, 2024 •
edited
Loading

Currently CreateOrUpdateCooccurrence will error if id is queried in the mutation.

The root cause is that id is not given in the resolver. We did not capture this error because we do not include id in test script.

This PR fixes the root cause and make sure it's tested properly.

Blocks cofacts/rumors-line-bot#379 .

@MrOrz MrOrz requested review from yhsiang, nonumpa and bil4444 January 2, 2024 17:50
@MrOrz MrOrz self-assigned this Jan 2, 2024
@coveralls
Copy link

coveralls commented Jan 2, 2024 •
edited
Loading

Coverage Status

coverage: 88.365%. remained the same
when pulling 940015a on fix-cooccurrence
into 4b00d58 on master.

@MrOrz MrOrz merged commit 8a34ef6 into master Jan 3, 2024
5 checks passed
@MrOrz MrOrz deleted the fix-cooccurrence branch January 3, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@nonumpa nonumpa nonumpa approved these changes

@yhsiang yhsiang Awaiting requested review from yhsiang

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrOrz @coveralls @nonumpa @bil4444