Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] Use Typescript in admin scripts #338

Merged
merged 17 commits into from
Nov 4, 2024
Merged

[3] Use Typescript in admin scripts #338

merged 17 commits into from
Nov 4, 2024

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented May 13, 2024 •
edited
Loading

This PR tries to turn src/scripts/blockUser into Typescript.

Since it's the first script turned into Typescript, multiple common utilities are being rewritten to Typescript as well, which includes

  • The logic that generates GraphQL context (extracted from src/index to new filesrc/contextFactory)
  • dataloaders
  • user util (src/util/user)
  • client util (src/util/client)
  • CreateOrUpdateArticleReplyFeedback
  • Small JSDoc fix on UpdateArticleReplyStatus

@MrOrz MrOrz changed the base branch from master to update-prettier June 23, 2024 20:09
@MrOrz MrOrz changed the base branch from update-prettier to ts-schema June 23, 2024 20:12
@MrOrz MrOrz changed the title Use Typescript in admin scripts [3] Use Typescript in admin scripts Jun 23, 2024
Base automatically changed from ts-schema to master June 24, 2024 06:11
@MrOrz MrOrz self-assigned this Jul 14, 2024
@coveralls
Copy link

coveralls commented Jul 14, 2024 •
edited
Loading

Coverage Status

coverage: 83.371% (+0.006%) from 83.365%
when pulling a656285 on ts-scripts
into 136c93e on master.

MrOrz added 17 commits November 4, 2024 01:04
@MrOrz
refactor: rewriting blockUser and util to TS
c933406
@MrOrz
refactor: blockUser script uses typescript defn from rumors-db
123c178
@MrOrz
refactor(CreateOrUpdateArticleReplyFeedback): rewrite into TS
f5f7c29
@MrOrz
fix: types
6847000
@MrOrz
fix(pacakge.json): add type for cli-progress
087605f
@MrOrz
feat(graphql): type dataloaders
19c9046 
- Not really typing every dataloader though, just type the Dataloaders class
@MrOrz
refactor(util): rewrite util/user to Typeascript
5fc2c88
@MrOrz
fix(package.json): typing lodash
815d695
@MrOrz
fix(dataLoaders): make _checkOrSetLoader don't return undefined
9660cae
@MrOrz
refactor(index): extract and type GraphQL context factory function
85c14c0
@MrOrz
refactor(util): assertUser can narrow down param
2c762cd
@MrOrz
refactor(CreateOrUpdateArticleReplyFactory): typing rootValue and con…
88e5061 
…text
@MrOrz
fix(graphql): property type updateArticleReplyStatus
209f2eb
@MrOrz
fix(util): getAvailableAvatarTypes handles undefined
81e06aa
@MrOrz
fix(util): fix user test
83ab1ac
@MrOrz
fix(CreateCategory): move error check in front of accessing data
2113d49
@MrOrz
fix(pacakge.json): fix posttest as it now imports typescript files
a656285
@MrOrz MrOrz marked this pull request as ready for review November 3, 2024 17:13
@MrOrz MrOrz merged commit 25f2df4 into master Nov 4, 2024
5 checks passed
@MrOrz MrOrz deleted the ts-scripts branch November 4, 2024 05:47
@MrOrz MrOrz mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@andyy0216 andyy0216 andyy0216 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrOrz @coveralls @andyy0216 @bil4444