Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase execution timeout #124

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

bammari
Copy link
Collaborator

@bammari bammari commented Sep 25, 2023

Increased execution timeout from 300 sec to 500 sec in notebook tests.

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c0f6c0b) 95.95% compared to head (b02e656) 95.95%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          29       29           
  Lines        1656     1656           
  Branches      251      255    +4     
=======================================
  Hits         1589     1589           
  Misses         35       35           
  Partials       32       32           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmisener
Copy link
Member

rmisener commented Oct 6, 2023

Hi @bammari, thanks so much for doing this! Can you explain why changing a lower-case word to an upper-case word and running CI again makes all the tests pass? Seems really weird.

@bammari
Copy link
Collaborator Author

bammari commented Oct 6, 2023

Hi @bammari, thanks so much for doing this! Can you explain why changing a lower-case word to an upper-case word and running CI again makes all the tests pass? Seems really weird.

@rmisener, sorry for the confusion! My access doesn't allow me to rerun CI so I committed a minor docstring change to kick off the workflow again. The deeper issue is this intermittent problem where tests pass but we get an error that the code coverage report fails to upload. Rerunning the CI one or more times typically resolves the issue however, we are currently looking into this as highlighted here: https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954

@rmisener
Copy link
Member

rmisener commented Oct 6, 2023

Haha, I get it. I just gave you better access to the repo, you shouldn't need to make silly changes anymore to re-run CI.

@jalving jalving merged commit b9600e2 into cog-imperial:main Oct 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants