Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[715] Enable handling of inverted latitude in reader.point #716

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

georgespill
Copy link
Contributor

reader.point raises a PointOutsideBounds error if the input coordinates are outside the dataset bounds. However, the current implementation assumes that bounds[1] < bounds[3]. This is not true for inverted latitude coordinates. This PR updates the implementation to handle the inverted case.

Fixes #715

See #696 for a similar issue

@vincentsarago
Copy link
Member

thanks @georgespill

do you thing we should had the same kind of warning as in https://github.com/cogeotiff/rio-tiler/pull/696/files#diff-aee02035a0c41599c6860bf04d8075994bb3f9e5b1d5d0595c0d02c5f4ddf596R50-R53 ?

would you be able to write a quick tests for this 🙏

@georgespill
Copy link
Contributor Author

Yep, adding the warning is a good suggestion. Have added that along with updating tests

@vincentsarago vincentsarago merged commit 8573dbe into cogeotiff:main Jul 31, 2024
8 checks passed
@georgespill
Copy link
Contributor Author

@vincentsarago would it be possible to publish a release with this fix included?

@vincentsarago
Copy link
Member

@georgespill yes, I'm just waiting on #726 to get merged 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reader.point assumes latitude coordinate is increasing
2 participants