-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding default_assets
for MultiBaseReader and STACReader
#722
Conversation
@mccarthyryanc I'll try to review/merge this PR this week. Quick question, are you planning to use this with TiTiler? right now this won't work without customizing the Dependencies because the default dependencies expect assets/expression to be set or it will raise a 500 errors. At runtime the dependencies can check if the item as Note: this could be resolved using the Render extension at a collection level |
Thanks for the review!
Yes, I'm using this with titiler. I already needed custom dependencies for some other inputs so it was simple enough to add in the |
@mccarthyryanc thanks for the PR, I've made some edits:
let's hope no one comes with the need of I'll wait for your 👍 before merging |
Awesome! Thanks for the changes @vincentsarago, those all look great! |
I have a specific use case when using
titiler
where I can't passassets
to theSTACReader
methods. As a solution to this, I added an optionaldefault_assets
attribute to be used like:PR includes tests and updates to docs.
ref: #720