-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CDF-23684] Fix update kafka or mqtt source in hosted extractor. #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
changed the title
[CDF-23684] Fix update hosted extractors source/destination
[CDF-23684] Fix update kafka or mqtt source in hosted extractor.
Jan 19, 2025
doctrino
commented
Jan 19, 2025
isNull: true should be supported for all APIs according to the design guide. Let's try chasing the teams owning those services to support it before adding a public option to configure it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 90.69% 90.70% +0.01%
==========================================
Files 149 149
Lines 22880 22883 +3
==========================================
+ Hits 20750 20756 +6
+ Misses 2130 2127 -3
|
haakonvt
reviewed
Jan 19, 2025
…ognite-sdk-python into fix-hosted-extrator-update
doctrino
commented
Jan 20, 2025
…ognite-sdk-python into fix-hosted-extrator-update
erlendvollset
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue is that these source uses a
{"setNull": True}
instead of of{"set": {}}
for clearing objects.Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.