add a small test for scheduler #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 69.56% 69.71% +0.14%
==========================================
Files 33 33
Lines 3434 3437 +3
Branches 402 402
==========================================
+ Hits 2389 2396 +7
+ Misses 890 886 -4
Partials 155 155
|
polomani
reviewed
Sep 19, 2024
Comment on lines
+84
to
+88
| public ScheduledJob<V> SetSchedule(string CronExpression) | ||
| { | ||
| Schedule = CrontabSchedule.Parse(CronExpression); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
why not having this in the constructor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dont really know where Im going with this, I just created this to see if we can catch the issue with incorrect cron expressions on the connector. Seems like incorrect expressions should already be caught by the NCrontab library, but for some reason we still ran into an issue by providing the wrong expression. 🤔