-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit some features #8
base: master
Are you sure you want to change the base?
Conversation
easy for wkhtmltopdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JiaKunUp, thanks for you PR.
continuous
seems good idea. I like it 😄
body.A4.landscape .sheet { width: 297mm; height: 209mm } | ||
body.A5 .sheet { width: 148mm; height: 209mm } | ||
body.A5.landscape .sheet { width: 210mm; height: 147mm } | ||
body.A3 .sheet { width: 297mm; height: 419mm;margin-left: auto; margin-right: auto; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the benefit of this. Could you pls explain it?
Anyway it seems better to write it in another line:
.sheet { margin-left: auto; margin-right: auto }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cognitom Thanks for replying, if I add these, papers will be displayed at middle of screen like:
not on left side of screen, only looks good😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I write at this place to make paper displayed at center default. If you think this feature is optional write it in another line is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have open an issue asking for centering the sheets as this PR. #20. I think centering the sheets is great for visual purpose for the clients/users a and I think it should be centered as default. I always for default center all the sheets using this:
.sheet {
margin: 0 auto;
}
Think about MS Word, or any other printing tools. Sheets are centered for default. Centering sheets for print is like a standard for the clients/users.
Hi @cognitom ,
I have edited some places, maybe it will be helpful for you:
Paper sizes
in paper.css, I make paper at middle of screen to make it looks better.Then I compress paper.css again.
Thanks