Add example for xarray groupby reduction causing memory pressure #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
reviewed
Aug 15, 2024
Co-authored-by: Florian Jetter <[email protected]>
| clim = arr.groupby("day").mean(dim="time") | ||
| anom = arr.groupby("day") - clim | ||
| anom_mean = anom.mean(dim="time") | ||
| with xarray.set_options(use_flox=False): |
There was a problem hiding this comment.
I'd suggest moving the xarray-related tests to test_xarray.py.
There was a problem hiding this comment.
I'd rather do this as a follow up, but the general idea is good
tests/benchmarks/test_xarray.py
Outdated
| ], | ||
| ) | ||
| def test_xarray_groupby_reduction(group_reduction_client, func): | ||
| pytest.importorskip("xarray") |
There was a problem hiding this comment.
Let's move these to the top of the module. There's no need to spin up clusters if we don't have xarray installed.
Co-authored-by: Hendrik Makait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each query runs around 50s, we are fine with spot-with-fallback since we mostly care about memory pressure