Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable broken test_delay_computation_start #1533

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Disable broken test_delay_computation_start #1533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/tpch/test_optimization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,13 @@ def test_optimization(query, dataset_path, fs, client, scale):
result.repartition(npartitions=1).optimize()


@pytest.mark.skip(
reason="This test does not work. See FIXME and https://github.com/dask/distributed/issues/8833."
)
def test_delay_computation_start(query, dataset_path, fs, client, scale):
func = getattr(dask_queries, f"query_{query}")
result = func(dataset_path, fs, scale).optimize()
# Client.compute unblocks as soon as update_graph finishes, i.e. graph is
# submitted and parsed. This is the time until the dashboard kicks off
# FIXME: Client.compute unblocks only until the graph is serialized and put onto
# the comm buffer. It should wait until update_graph finishes, i.e. graph is
# submitted, parsed, and the tasks have been added onto the scheduler.
client.compute(result)
Loading