Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automated tests on PRs and run them only once per week #1534

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

hendrikmakait
Copy link
Member

No description provided.

@hendrikmakait hendrikmakait changed the title Disable automated tests on PRs Disable automated tests on PRs and run them only once per week Aug 20, 2024
@phofl
Copy link
Contributor

phofl commented Aug 20, 2024

i.e. we have to make sure that a test passes locally because it won't be run on CI when we create a PR, correct?

@hendrikmakait
Copy link
Member Author

hendrikmakait commented Aug 20, 2024

i.e. we have to make sure that a test passes locally because it won't be run on CI when we create a PR, correct?

We're still able to fire off manual runs via the "Run workflow" button on https://github.com/coiled/benchmarks/actions/workflows/tests.yml

A better way of handling partial runs would be nice, but is out of scope.

@phofl phofl merged commit 49679fc into main Aug 20, 2024
5 checks passed
@phofl phofl deleted the disable-tests-on-PRs branch August 20, 2024 13:35
@phofl
Copy link
Contributor

phofl commented Aug 20, 2024

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants