fix: deprecate v1 swap amountReference to #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
force-pushed
the
alessey/deprecate-v1-reference-to
branch
from
37921d4 to
fb0eee8
Compare
alessey
force-pushed
the
alessey/deprecate-v1-reference-to
branch
from
fb0eee8 to
05d3ab1
Compare
alessey
force-pushed
the
alessey/deprecate-v1-reference-to
branch
from
05d3ab1 to
b2616af
Compare
alessey
force-pushed
the
alessey/deprecate-v1-reference-to
branch
from
b2616af to
0bdce99
Compare
dschlabach
reviewed
Jan 22, 2025
| @@ -14,7 +16,7 @@ vi.mock('../network/request'); | |||
|
|
|||
| const testFromAddress = '0x6Cd01c0F55ce9E0Bf78f5E90f72b4345b16d515d'; | |||
There was a problem hiding this comment.
Suggested change
| const testFromAddress = '0x6Cd01c0F55ce9E0Bf78f5E90f72b4345b16d515d'; | |
| const testFromAddress: Address = '0x6Cd01c0F55ce9E0Bf78f5E90f72b4345b16d515d'; |
dschlabach
reviewed
Jan 22, 2025
| it('should return an error for an unsupported amount reference', async () => { | ||
| const mockParams = { | ||
| useAggregator: true, | ||
| fromAddress: testFromAddress as `0x${string}`, |
There was a problem hiding this comment.
Suggested change
| fromAddress: testFromAddress as `0x${string}`, | |
| fromAddress: testFromAddress, |
alessey
commented
Jan 22, 2025
| @@ -30,6 +30,7 @@ export function BuyAmountInput() { | |||
| )} | |||
| placeholder="0.0" | |||
| delayMs={1000} | |||
| inputMode="decimal" | |||
There was a problem hiding this comment.
sets the Buy component to use the number keypad on mobile devices
alessey
force-pushed
the
alessey/deprecate-v1-reference-to
branch
from
4fca36f to
5b9528c
Compare
alessey
force-pushed
the
alessey/deprecate-v1-reference-to
branch
from
5b9528c to
3d34cd3
Compare
abcrane123
approved these changes
Jan 23, 2025
cpcramer
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?