Normalize package name detected by pip list #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
approved these changes
Mar 2, 2024
cottsay
force-pushed
the
cottsay/normalize-pkg-names
branch
from
d2621b5 to
b503500
Compare
cottsay
force-pushed
the
cottsay/normalize-pkg-names
branch
from
b503500 to
4e45db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern Python (or setuptools?) versions no longer normalize package names during installation. This isn't a problem in any of the current colcon packages, but if any are ever introduced which contain an underscore, normalization will be necessary to ensure that we properly detect the package name on all supported Python versions in the matrix.
Requires #23 to actually be tested by CI