Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package identification / build tests #35

Merged
merged 9 commits into from
Jun 28, 2024

Conversation

luca-della-vedova
Copy link
Member

No description provided.

Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
test/test_build.py Outdated Show resolved Hide resolved
test/test_build.py Outdated Show resolved Hide resolved
@luca-della-vedova luca-della-vedova marked this pull request as ready for review June 24, 2024 05:00
@luca-della-vedova
Copy link
Member Author

Turns out the Windows test was failing because the executable was missing a .exe extension, addressed in f344aff.
I noticed that codecov was added but it seems not to run for this PR, I tried closing and reopening but it doesn't seem to help, I can create a new PR if needed

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.98%. Comparing base (718630a) to head (f344aff).

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #35       +/-   ##
==========================================
+ Coverage   0.00%   46.98%   +46.98%     
==========================================
  Files          6        6               
  Lines        166      166               
  Branches       0       24       +24     
==========================================
+ Hits           0       78       +78     
+ Misses       166       74       -92     
- Partials       0       14       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay
Copy link
Member

cottsay commented Jun 28, 2024

I noticed that codecov was added but it seems not to run for this PR, I tried closing and reopening but it doesn't seem to help, I can create a new PR if needed

This was my fault, and I addressed it in colcon/ci#32. Coverage uploads from forks weren't working.

Coverage +46.98%

🎉 Nice work!

@cottsay cottsay merged commit 9fdb14f into colcon:main Jun 28, 2024
34 checks passed
@luca-della-vedova luca-della-vedova deleted the luca/add_build_tests branch August 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants