Cli cleanup #65
Draft
Cli cleanup #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I worry that the logger hides messages from less technical users. E.g. to get the messages you have to be able to configure the logger. What do you think of a "verbose" mode? Most users in this area would probably be interested in some feedback about what is happening. |
|
Sure for the CLI I can direct the logging to a log file and make the log messages show the identity of the molecule so it's clear which one they refer to as its not as clear when running with dask rather than one by one in a notebook. |
|
That's useful. I'll see later how to make sure that the users still get some kind of printing if they want to. Maybe just a function that sets logger. Go head and merge when you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some the CLI performance and cleans up some of the messages printed to screen but not all of them.