Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vad option #147

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Vad option #147

merged 11 commits into from
Feb 21, 2024

Conversation

makaveli10
Copy link
Collaborator

@makaveli10 makaveli10 commented Feb 20, 2024 •
edited
Loading

  • give client an option to not use vad as the accuracy is slightly better without vad
  • send end of audio message to server in case the audio file is fully consumed so that the server can cleanup nicely.

zoq
zoq approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@makaveli10 makaveli10 merged commit 1db94ea into collabora:main Feb 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoq zoq zoq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makaveli10 @zoq