Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backend through config #17

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

mark-cooper
Copy link
Member

  • Add backend through config
  • Add spec for rails backend

@mark-cooper mark-cooper requested a review from kspurgin July 18, 2024 20:45
@mark-cooper
Copy link
Member Author

This is a do not merge PR. It just gave me a chance to review this gem quickly with some cleanup.

And yes, I agree it doesn't look like we need this! If there's some merit to streamlining the cache key generation for auths/vocabs then great, that could be added to the client. But in a Rails context, just use the Rails cache directly. In other contexts, just use active support cache. This gem adds a fair bit of overhead to not do all that much and be another separate gem to maintain.

That would mean going forward, for any re-implementation of the importer, there would be no refcache dependency. All caching will be done through Rails.cache.

@kspurgin if you agree I think we can close this, plan to archive this repo at some point in the future, and perhaps create an issue for the client to do the useful part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant