Other italian translations #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauritsvanrees
requested changes
Sep 21, 2020
| @@ -257,7 +257,7 @@ | |||
| </div> | |||
|
|
|||
| <select name="current_assignee"> | |||
| <option value=""> | |||
| <option value="" i18n:translate="Poi_label_noneResponsibleManager"> | |||
There was a problem hiding this comment.
What does the label 'no change' have to do with a 'none responsible manager?'
| <span class="issueChange" | ||
| i18n:translate="" | ||
| i18n:domain="plone" | ||
| i18n:domain="Poi" |
There was a problem hiding this comment.
Are you sure this isn't in the plone translation domain?
I am not sure, just asking.
| @@ -244,8 +244,10 @@ def transitions_for_display(self): | |||
| transitions.append(dict(value='', label=PMF(u'No change'), | |||
| checked="checked")) | |||
| for tdef in wftool.getTransitionsFor(context): | |||
| label_value = tdef['title_or_id'] | |||
| label_value = PMF(label_value) | |||
There was a problem hiding this comment.
You are using PMF here, which is for the plone domain.
But in the workflow xml files you are setting the Poi domain.
So here it should be _(label_value) I think.
| @@ -49,7 +57,7 @@ | |||
| <permission-role>TrackerManager</permission-role> | |||
| </permission-map> | |||
| </state> | |||
| <state state_id="in-progress" title="In progress"> | |||
| <state state_id="in-progress" title="In progress" i18n:attributes="state_id"> | |||
There was a problem hiding this comment.
It seems to me we should not translate the state_id, but the title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.