Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve rss/atom feed subscription #13

Merged
merged 17 commits into from
Feb 4, 2024
Merged

improve rss/atom feed subscription #13

merged 17 commits into from
Feb 4, 2024

Conversation

taevel02
Copy link
Contributor

Changes

  • You may no longer get old items when you subscribe to a feed.
  • You don't have to enter an RSS/ATOM address when subscribing to a feed! Simply enter your main blog address or YouTube link etc and we'll subscribe you to the feed automatically.

Related Issues

Comment

  • Should we send a notification when a subscription fails or when we find and subscribe to an RSS/ATOM address? I would welcome some discussion on this.

@taevel02
Copy link
Contributor Author

In addition, I've changed the way feed links are checked, as you can see in the first fix commit.

@taevel02 taevel02 marked this pull request as draft January 22, 2024 12:54
@taevel02 taevel02 marked this pull request as ready for review January 22, 2024 13:25
@taevel02
Copy link
Contributor Author

I drafted PRs for a while due to some considerations, but thanks to your review, I was able to reopen PRs quickly. May I request it again after I fix the issue with create_new_items? It looks like it keeps truncating even though it has most_recent. Along with review reflection, of course.

@parksb
Copy link
Member

parksb commented Jan 22, 2024

I drafted PRs for a while due to some considerations, but thanks to your review, I was able to reopen PRs quickly. May I request it again after I fix the issue with create_new_items? It looks like it keeps truncating even though it has most_recent. Along with review reflection, of course.

Absolutely :) Thanks for your efforts.

@taevel02 taevel02 requested a review from parksb January 24, 2024 11:34
@taevel02 taevel02 closed this Jan 29, 2024
@taevel02 taevel02 reopened this Jan 29, 2024
@taevel02
Copy link
Contributor Author

For some reason, the polling frequency is not working properly, and this needs issue handling as well.

@taevel02
Copy link
Contributor Author

Why getting build errors on macos? Please help.

@parksb
Copy link
Member

parksb commented Jan 30, 2024

Why getting build errors on macos? Please help.

It seems a temporary error.

@parksb
Copy link
Member

parksb commented Jan 30, 2024

For some reason, the polling frequency is not working properly, and this needs issue handling as well.

Could you explain in more detail about this problem?

@taevel02
Copy link
Contributor Author

taevel02 commented Jan 30, 2024

For some reason, the polling frequency is not working properly, and this needs issue handling as well.

Could you explain in more detail about this problem?

You can see that it stops the thread when the MacOS goes to sleep, as shown below.
I think this is happening after my feature update, it wasn't before. The issue returns to normal after completely closing and re-opening the app.

Image 1-30-24 at 19 44

@taevel02
Copy link
Contributor Author

taevel02 commented Feb 1, 2024

For some reason, the polling frequency is not working properly, and this needs issue handling as well.

Could you explain in more detail about this problem?

You can see that it stops the thread when the MacOS goes to sleep, as shown below. I think this is happening after my feature update, it wasn't before. The issue returns to normal after completely closing and re-opening the app.

After using it for a couple days, it appears that there was an issue with two HTTP calls. This seems to have gone away for now. On my Mac right now, it works just as it did in version 0.1.7.

Copy link
Member

@parksb parksb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a minor comment.

Co-authored-by: Simon Park (박성범) <[email protected]>
@parksb parksb merged commit 6e56732 into collie-reader:main Feb 4, 2024
3 checks passed
@parksb
Copy link
Member

parksb commented Feb 4, 2024

Thank you :)

@taevel02 taevel02 deleted the feature/improve-rss branch February 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants