feat: update research guide #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbarah
approved these changes
Dec 2, 2024
barbarah
force-pushed
the
feat-update-research-guide
branch
from
6dcfd60 to
e583972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards incompatible PR that updates the backend code of the research guide. This update is necessary due to some changes that have been made to the data model of the research guide in the knowledge graph.
This update means:
identifierin theResearchGuidetype has been removed.namehas been added to 'level 1' research guides. This name can be used as section headers in the overview page, e.g. "How to do Provenance Research", "Locations", "Topics".alternateNameandcontentReferenceTimehave been added to 'level 2' and 'level 3' research guides. These props are known in the design as the alternative names for the main name (e.g. "Kunstzaal Van Lier, Carel van Lier, Leendert van Lier") and as the "Period of activity".This PR also fixes some failing integration tests that have changed since they were last run, some 5 months ago.