-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Migrate to reanimated 2 #68
base: main
Are you sure you want to change the base?
Refactor: Migrate to reanimated 2 #68
Conversation
Hey @MasonLe2497! Thank you for this great PR! I've been thinking about switching Modalfy to Reanimated v2 for a long time, just was waiting to ship some other features & fixes before that. I'll go over your PR and try to get it merge as soon as I'll have a minute! 💪 |
I tested on android device, and it works with 60fps |
But with this PR, transitionOptions must be a 'worklet' function return ViewStyle |
Yeah, I suspected that the switch to Reanimated 2 would be a breaking change and would require a major app update, shouldn't be much of an issue if the doc has proper migration guide. |
Hey! I'm looking into migrating to this library and v2 reanimated support is something on our list, is there any chance this is on the docket still? Love the lib design so far too nice work |
@MasonLe2497 Thinking about patching this into my project, have you used in production at all? Thanks! |
hey! is this still being worked on? I'd love to see modalfy having support for reanimated 😄 |
hi @tonihm96. no this is currently not being worked on. we'll try to keep you posted once this gets on top of our todo list 👍 |
would love to see modalfy having support for reanimated ! |
Is the transition to reanimated still under consideration? |
Will it migrate to reanimated? |
This PR uses Reanimated 2 to be supported by JSI instead of Bridge