Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove build step from ui 👷‍♀️ #26

Merged
merged 23 commits into from
Mar 29, 2024
Merged

feat: remove build step from ui 👷‍♀️ #26

merged 23 commits into from
Mar 29, 2024

Conversation

ramiAbdou
Copy link
Member

@ramiAbdou ramiAbdou commented Mar 29, 2024

Description ✏️

Closes #19.
Closes #22.

This PR does the following:

  • Refactors the following ui components to no longer use SCSS/PostCSS and instead uses Tailwind:
    • Checkbox
    • Dropdown
    • Modal
    • Radio
    • Select
    • Toast
  • Removes the build step from ui, including any packages that were needed for the build process such as rollup and all of its plugins.
  • Moved ui components from the src/ui folder to the src/components folder.
  • Configures the prettier-plugin-tailwindcss properly by updating the Prettier configuration.
  • Creates a new @oyster/tailwind package that houses the base Tailwind configuration, pointing to all React component files for Intellisense + Prettier purposes. Our FE applications will extend this base configuration and simply just update the content property.
  • Adds keyframe animations that previously lived in SCSS to the base Tailwind config.
  • Updates the Tailwind Intellisense VSCode extension by updating the experimental.configFile to the newly established base Tailwind config.
  • Added moduleResolution: "Bundler" to the core package.
  • Refactors findMemberByEmail since it started giving issues when updating the above.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Mar 29, 2024
@ramiAbdou ramiAbdou merged commit 3ea8939 into main Mar 29, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the rami/scss branch March 29, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the build step from core-ui 👷‍♀️ Remove any remaining SCSS in core-ui 💅
1 participant