Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link leaderboard to members' profiles 🔗 #694

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

BeteabTefera
Copy link
Contributor

Enhancement to make leaderboard clickable and navigate to the clicked user directory

Describe what this PR does.

This PR adds the List component so the leaderboards populated for active streak under Home and the Points leaderboard under points can have a clickable profile. If user A is interested in User B who is on a leaderboard, they don't have to go to the directory to search for them but instead can directly click on the profile, which will lead them to the directory of the specified user.

feature

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@BeteabTefera
Copy link
Contributor Author

@tomas-salgado this PR is in regards to discussion on the following thread

@tomas-salgado
Copy link
Collaborator

@BeteabTefera Nice work! I tried running this locally and the functionality is great, but I think we should change the UI so that only the name is clickable instead of the entire Leaderboard item. This would make it consistent with the rest of the website. Look at the Resources and Company Reviews page for examples, and also check out that code. Lmk if you have any questions!

Screenshot 2025-01-07 at 11 59 50 AM

@tomas-salgado tomas-salgado changed the title 'Clickable Leaderboard Profiles' feat: link leaderboard to members' profiles 🔗 Jan 7, 2025
@BeteabTefera
Copy link
Contributor Author

@tomas-salgado apologies on the late reply, working on making those changes now

@BeteabTefera
Copy link
Contributor Author

BeteabTefera commented Jan 17, 2025

@tomas-salgado alright changes as per requested are made, see below:

demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants