Skip to content

Commit

Permalink
TEMP: remove contrib.scoverage.worker
Browse files Browse the repository at this point in the history
  • Loading branch information
bishabosha committed Sep 16, 2024
1 parent 624b434 commit 6d31805
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions contrib/package.mill
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ object `package` extends RootModule {
def compileModuleDeps = Seq(build.scalalib)

def testTransitiveDeps =
super.testTransitiveDeps() ++ Seq(worker.testDep(), worker2.testDep())
super.testTransitiveDeps() ++ Seq(/*worker.testDep(), */ worker2.testDep())

def testArgs = T {
super.testArgs() ++
Expand All @@ -128,18 +128,19 @@ object `package` extends RootModule {
super.testModuleDeps ++
Seq(build.scalalib, build.scalajslib, build.scalanativelib, build.contrib.buildinfo)

// TODO: (Scala 3) temporarily disable until decision on compatibility with Scala 3
// Worker for Scoverage 1.x
object worker extends build.MillPublishScalaModule {
// scoverage is on an old Scala version which doesnt support scalafix
def fix(args: String*): Command[Unit] = T.command {}
def compileModuleDeps = Seq(build.main.api)
def moduleDeps = Seq(scoverage.api)
def testDepPaths = T { Seq(compile().classes) }

// compile-time only, need to provide the correct scoverage version at runtime
def compileIvyDeps = Agg(build.Deps.scalacScoveragePlugin)
def scalaVersion = build.Deps.scalaVersionForScoverageWorker1
}
// object worker extends build.MillPublishScalaModule {
// // scoverage is on an old Scala version which doesnt support scalafix
// def fix(args: String*): Command[Unit] = T.command {}
// def compileModuleDeps = Seq(build.main.api)
// def moduleDeps = Seq(scoverage.api)
// def testDepPaths = T { Seq(compile().classes) }

// // compile-time only, need to provide the correct scoverage version at runtime
// def compileIvyDeps = Agg(build.Deps.scalacScoveragePlugin)
// def scalaVersion = build.Deps.scalaVersionForScoverageWorker1
// }

// Worker for Scoverage 2.0
object worker2 extends build.MillPublishScalaModule {
Expand Down

0 comments on commit 6d31805

Please sign in to comment.