Skip to content

Commit

Permalink
Removed Better-Files integration tests (#1906)
Browse files Browse the repository at this point in the history
They where only working on very limited platforms (Java 8 on Linux) and even then produced flaky results.

Pull request: #1906
  • Loading branch information
lefou authored Jun 23, 2022
1 parent 12e0775 commit e50fa4a
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 135 deletions.
6 changes: 0 additions & 6 deletions build.sc
Original file line number Diff line number Diff line change
Expand Up @@ -928,12 +928,6 @@ object integration extends MillScalaModule {
"fd8dc2b41ce70269889320aeabf8614fe1e8fbcb",
T.dest / "jawn"
),
"MILL_BETTERFILES_REPO" ->
shared.downloadTestRepo(
"pathikrit/better-files",
"ba74ae9ef784dcf37f1b22c3990037a4fcc6b5f8",
T.dest / "better-files"
),
"MILL_AMMONITE_REPO" ->
shared.downloadTestRepo(
"lihaoyi/ammonite",
Expand Down
9 changes: 0 additions & 9 deletions docs/antora/modules/ROOT/pages/Common_Project_Layouts.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -380,15 +380,6 @@ integration tests and examples:
A small single-module cross-build, with few sources, minimal dependencies, and
wired up for publishing to Maven Central.

=== Better-Files

* {mill-github-url}/blob/main/integration/thirdparty/local/resources/better-files/build.sc#L1[Mill Build]

A collection of small modules compiled for a single Scala version.

Also demonstrates how to define shared configuration in a `trait`, enable Scala
compiler flags, and download artifacts as part of the build.

=== Jawn

* {mill-github-url}/blob/main/integration/thirdparty/local/resources/jawn/build.sc#L1[Mill Build]
Expand Down
1 change: 0 additions & 1 deletion integration/thirdparty/forked/src/Tests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package forked

object AcyclicTests extends AcyclicTests(fork = true)
object AmmoniteTests extends AmmoniteTests(fork = true)
object BetterFilesTests extends BetterFilesTests(fork = true)
object JawnTests extends JawnTests(fork = true)
object UpickleTests extends UpickleTests(fork = true)
object CaffeineTests extends CaffeineTests(fork = true)
86 changes: 0 additions & 86 deletions integration/thirdparty/local/resources/better-files/build.sc

This file was deleted.

32 changes: 0 additions & 32 deletions integration/thirdparty/local/src/BetterFilesTests.scala

This file was deleted.

1 change: 0 additions & 1 deletion integration/thirdparty/local/src/local/Tests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package local

object AcyclicTests extends AcyclicTests(fork = false)
object AmmoniteTests extends AmmoniteTests(fork = false)
object BetterFilesTests extends BetterFilesTests(fork = false)
object JawnTests extends JawnTests(fork = false)
object UpickleTests extends UpickleTests(fork = false)
object CaffeineTests extends CaffeineTests(fork = false)

0 comments on commit e50fa4a

Please sign in to comment.