Refactor Jvm methods to match specified signatures #3977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3772
Refactor
Jvm.scala
to consolidate subprocess and classloader spawning operations into four specified signatures.Refactor
callSubprocess
method:call
.call
signature.jvmCommandArgs
to generate command arguments.os.call
with the updated parameters.Refactor
runSubprocess
method:spawn
.spawn
signature.jvmCommandArgs
to generate command arguments.os.spawn
with the updated parameters.Add
spawnClassloader
method:spawnClassloader
signature.mill.api.ClassLoader.create
to create a classloader.Add
callClassloader
method:callClassloader
signature.spawnClassloader
to create a classloader and set it as the context classloader.Add tests in
JvmTests.scala
:call
method.spawn
method.callClassloader
method.spawnClassloader
method.