WIP fix runBackground with -i/--no-server
#4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might have been the cause of a lot of flakiness that seems to have gone away with #4254, as the server exiting caused the
runBackgroundcalls to exit causing the http servers to exit and fail to pick up requests.Might have been caused by com-lihaoyi/os-lib#324 which made
destroyOnExitthe default for spawned subprocesses. This PR explicitly disablesdestroyOnExitfor the subprocesses wherebackground = trueCovered by a new
integration.invalidationtest that runs under bothserverandfork, that previously failed when run underfork