Skip to content

rpc: rename CompatMode::V0_37 to V1 #33

rpc: rename CompatMode::V0_37 to V1

rpc: rename CompatMode::V0_37 to V1 #33

GitHub Actions / clippy succeeded Jan 25, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (2)

cometbft/src/chain/id.rs|60 col 16| error: this as_str is redundant and can be removed as the method immediately following exists on String too
--> cometbft/src/chain/id.rs:60:16
|
60 | self.0.as_str().as_bytes()
| ^^^^^^^^^^^^^^^^^ help: try: as_bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_as_str
note: the lint level is defined here
--> cometbft/src/lib.rs:10:5
|
10 | warnings,
| ^^^^^^^^
= note: #[deny(clippy::redundant_as_str)] implied by #[deny(warnings)]
cometbft/src/crypto/ed25519/signing_key.rs|41 col 9| error: use of a fallible conversion when an infallible one could be used
--> cometbft/src/crypto/ed25519/signing_key.rs:41:9
|
41 | ed25519_consensus::SigningKey::try_from(src.0)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: From::from
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: #[deny(clippy::unnecessary_fallible_conversions)] implied by #[deny(warnings)]