-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible file widget #3807
Flexible file widget #3807
Conversation
code based on flexible image widget
For the FlexibleFileWidget we do not use UserUploadMultiple, so the return value for this widget should not be in a list.
@amickan do you think these tests are enough? I've adapted existing tests from the |
app/grandchallenge/components/static/components/js/flexible_file_widget.js
Outdated
Show resolved
Hide resolved
app/grandchallenge/components/templates/components/file_search_widget.html
Outdated
Show resolved
Hide resolved
The tests look comprehensive to me. The only thing that might be worth an additional test is the search view (see also the comment I left about the search fields). I don't think we have a test for the image search view, maybe they can be combined? |
app/grandchallenge/cases/templates/cases/flexible_image_widget.html
Outdated
Show resolved
Hide resolved
We do have a test for the image search view, just found it after writing a test for the file search results view. I did not combine at the moment... I can pick that up when I will reduce the duplication between the two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add the flexible file widget. The widget is not yet used on any form.