Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managements views for algorithm interfaces for phases #3812

Merged
merged 12 commits into from
Feb 5, 2025

Conversation

amickan
Copy link
Contributor

@amickan amickan commented Jan 31, 2025

This adds the management views for algorithm interfaces for phases.
The views are only accessible to staff users, and only for algorithm submission phases that are not external.
The logic behind the views is the same as for the algorithm interfaces, but it only made sense to refactor the create view logic, and parts of the templates.

image

Part of https://github.com/DIAGNijmegen/rse-roadmap/issues/153

@amickan amickan marked this pull request as ready for review January 31, 2025 12:24
@amickan amickan requested a review from jmsmkn as a code owner January 31, 2025 12:24
Copy link
Member

@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some small comments.

app/config/urls/challenge_subdomain.py Show resolved Hide resolved
app/grandchallenge/evaluation/urls.py Outdated Show resolved Hide resolved
app/grandchallenge/evaluation/views/__init__.py Outdated Show resolved Hide resolved
app/grandchallenge/evaluation/views/__init__.py Outdated Show resolved Hide resolved
@jmsmkn jmsmkn removed their assignment Feb 4, 2025
@amickan amickan merged commit d840750 into feat_optional_inputs Feb 5, 2025
8 checks passed
@amickan amickan deleted the interfaces_for_phases_views branch February 5, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants