Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-3401: Remove all donationType integration and tests #429

Merged
merged 2 commits into from
Jun 25, 2024
Merged

ENG-3401: Remove all donationType integration and tests #429

merged 2 commits into from
Jun 25, 2024

Conversation

AndyEPhipps
Copy link
Contributor

@AndyEPhipps AndyEPhipps commented Jun 25, 2024 •
edited
Loading

Turns out this didn't make sense to include the donationType radiobuttons any more at all, so just removing all integrations and tests.

@AndyEPhipps AndyEPhipps self-assigned this Jun 25, 2024
@AndyEPhipps AndyEPhipps requested a review from KrupaPammi June 25, 2024 08:35
@AndyEPhipps
Copy link
Contributor Author

Ahh, thanks for removing those extra selectors @KrupaPammi

@KrupaPammi
Copy link
Contributor

@AndyEPhipps I've tested this, works as expected.

@AndyEPhipps
Copy link
Contributor Author

Thanks Krupa 🙌

@AndyEPhipps AndyEPhipps merged commit cfbe10e into master Jun 25, 2024
7 checks passed
@AndyEPhipps AndyEPhipps deleted the ENG-3401_remove_donationType_radio_buttons branch June 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrupaPammi KrupaPammi KrupaPammi approved these changes

Assignees

@AndyEPhipps AndyEPhipps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyEPhipps @KrupaPammi