Verify hashes of monero cli on download #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Looks good, thanks for this. Just one change to return an error instead of panic.
If you have time, it would be great to look into a CI job that can test this functionality across platforms. This might require an additional option to the swap cli like "setup" which would just download the rpc software and then bail.
delta1
approved these changes
Mar 22, 2024
|
Thanks for the fix and merge! Been busier lately |
|
did you compute the hashes yourself or are they identical to the ones on https://www.getmonero.org/downloads/hashes.txt? I need to update the hashes because I'm bumping the rpc version. |
|
Taken from the monero hashes page, not computed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #673
Hardcodes hashes and checks against them, reviewers should use pgp verification of the hashes I've included here to confirm them.
Also bumps the MacOS arm64 version to match the version string for other platforms.