2024 Elantra car Unrecognized

[1okko]

Describe the bug

2024 Elantra car Unrecognized

Which car does this affect?

2024 HYUNDAI Elantra

Provide a route where the issue occurs

d01e5725e5587ae3/00000001--a4126f0d93/0

openpilot version

0.9.7

Additional info

It can be confirmed that the vehicle is a CAN and a camera SCC

[sshane]

Has a CAN FD radar bus. Please try this branch: https://github.com/commaai/openpilot/tree/cn7c-elantra

[1okko]

ok.i will try and let you know.

[1okko]

d01e5725e5587ae3/00000000--178533cb2e/1

it works well，thanks

[1okko]

拥有CAN FD雷达总线。请尝试这个分支：https://github.com/commaai/openpilot/tree/cn7c-elantra

d01e5725e5587ae3/00000000--178533cb2e/1

效果很好，谢谢

[1okko]

d01e5725e5587ae3/00000000--178533cb2e/1

it works well，thanks

d01e5725e5587ae3/00000000--178533cb2e/1

it works well，thanks

[sshane]

Nice! Can you drive more to gather more lateral control data? I'll get commaai/openpilot#30219 cleaned up and merged shortly after once we verify that lateral control is as we expect (not too much or too little lateral acceleration)

[1okko]

d01e5725e5587ae3/00000000--178533cb2e/1

d01e5725e5587ae3/00000000--178533cb2e/1 this not enough？

[sshane]

Need some more curves I believe!

[1okko]

Need some more curves I believe!

ok， i will drive it today

[1okko]

Need some more curves I believe!

d01e5725e5587ae3/00000002--3ec9e0ec2a/0

[sshane]

High speed (> 80 km/h) and engaged curves I mean

[sshane]

@1okko can you get more driving data please? Then we can merge!

[1okko]

@1okko can you get more driving data please? Then we can merge!

d01e5725e5587ae3/00000003--ecb5e1500a/2

[sshane]

Dongle, platform, VIN	Name from VIN 🆚 CarDocs	Segments	Bad seg tags	Good seg tags
d01e5725e5587ae3 HYUNDAI_ELANTRA_2021 000000000........	None 🆚 None	4 routes, 94 segments (1.6 hours)		- all lat active: 51 - no input all lat active: 42

[sshane]

Need a little more sharper turns at high speeds, the torqued learner doesn't have many data points there.

[1okko]

Need a little more sharper turns at high speeds, the torqued learner doesn't have many data points there.

ok

[1okko]

Need a little more sharper turns at high speeds, the torqued learner doesn't have many data points there.

d01e5725e5587ae3/00000004--9eae7430ad/0

[sshane]

Dongle, platform, VIN	Name from VIN 🆚 CarDocs	Segments	Bad seg tags	Good seg tags
d01e5725e5587ae3 HYUNDAI_ELANTRA_2021 000000000........	None 🆚 None	6 routes, 181 segments (3.0 hours)	- high lateral accel factor: 1	- all lat active: 87 - no input all lat active: 57 - valid torque params: 78

It starts high (still learning), but settles into 3.5 and falling (still hasn't fully learned), so this looks expected.

[sshane]

I forgot this port requires changing the length of LFAHDA_MFC, we'll have to put this off for now until we have time for a car porting sprint. Feel free to keep driving on the branch!

[1okko]

I forgot this port requires changing the length of LFAHDA_MFC, we'll have to put this off for now until we have time for a car porting sprint. Feel free to keep driving on the branch!

How can I test this fork on c3+red panda kit?

[0xDeadcell]

Is this ready yet? I just got a Hyundai Elantra Hybrid 2024 and looking to test this out or help out if needed, lmk.