Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: support Elantra 2024 #30219

Closed
wants to merge 10 commits into from
Closed

Hyundai: support Elantra 2024 #30219

wants to merge 10 commits into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Oct 10, 2023

it's camera-SCC like the Kona EV 2022. Also, our recent understanding of SCC or RDR in the radar FW seems to describe if it sends SCC!


Waiting on user to test 3X, radar might be CAN FD

@github-actions github-actions bot added the car vehicle-specific label Oct 10, 2023
@sshane sshane changed the title Hyundai: car port for 2024 Elantra Hyundai: support 2024 Elantra Oct 10, 2023
@sshane sshane changed the title Hyundai: support 2024 Elantra Hyundai: support Elantra 2024 Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

⚠️ This PR makes changes to CARS.md ⚠️

➕ Added

Make Model Supported Package ACC No ACC accel below No ALC below Steering Torque Resume from stop Hardware Needed Video
Hyundai Elantra 2024 Smart Cruise Control (SCC) Stock 0 mph 0 mph
Parts- 1 Hyundai K connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here

@sshane sshane marked this pull request as draft October 13, 2023 04:02
gaurovgiri

This comment was marked as spam.

@sshane sshane marked this pull request as ready for review October 24, 2023 08:48
Copy link
Contributor

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 24, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Dec 1, 2023
@royjr royjr mentioned this pull request Dec 10, 2023
20 tasks
@sshane sshane reopened this Dec 11, 2023
@sshane
Copy link
Contributor Author

sshane commented Jan 16, 2024

From the Discord:

TimPrice — Today at 3:04 PM
I've been too sick to drive a regular shift all week, but I did put about 6 hrs of driving in going to the store and such.

The only real issue is that it flashes and sounds a warning for "Communication Lagging: Take Control Immediately" about once every 75 minutes. This actually clears itself up after about two seconds so I've never actually had to take control, so I don't know how big of an issue this actually is.

The Hyundai still also has those annoying "Consider Taking a Coffee Break" warnings because it thinks I'm not paying attention whenever I use Comma AI to drive, but I don't think there's anything that can be done about that

Those and the lack of fingerprinting are the only issues.

All together it's finally usable for a 2024 Elantra.

@sshane
Copy link
Contributor Author

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024 Elantra car Unrecognized
3 participants