Subaru LKAS Angle safety model #2020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
changed the title
|
Thanks for the PR, this has been on my todo list too long |
bravochar
changed the title
5 tasks
bravochar
force-pushed
the
ascent-2023
branch
from
f0ccd51
to
ad2c16d
Compare
bravochar
force-pushed
the
ascent-2023
branch
from
ad2c16d
to
6057481
Compare
|
I just rebased this so it's more up-to-date. My OpenDBC and OpenPilot PRs will be blocked until this is merged. Is there anything I'm missing here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer (3-camera) EyeSight systems need angle-based steering controls, which means new safety models. Most of this is lifted from jnewb1's abandoned branch.
The gist is that we're adding a new message and bus for the LKAS angle controls and using the Gen2 alt bus for most everything else.