Stream.stream_forward and Stream.stream_backward should handle gaps #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see an Issue for this, apologies if there is one.
Currently, if
Stream.stream_forward
orStream.stream_backward
is called on a stream containing "gaps" in then duplicate events may be streamed.For example, imagine two streams each with three events:
Resulting in the $all stream:
If the first stream is hard deleted, resulting in:
and
stream_forward
is called with a batch size of1
, then according to the logic here the following calls would be made:The problem being that the
next_version
is set to the previous version + the number of events returned in the last batch - meaning that since there are no events 1-3 the first four calls all return event 4.The reverse is true for
stream_backward
Resolved by setting the
next_version
to the last event retrieved plus or minus 1